Re: [PATCH] Reduce noise from tsort

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-patches(at)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Martijn van Oosterhout <kleptog(at)svana(dot)org>
Subject: Re: [PATCH] Reduce noise from tsort
Date: 2006-04-19 20:46:59
Message-ID: 200604192246.59653.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Well, I vote we take it out, which would eliminate these warnings
> instead of just shorten them. On a platform where tsorting a
> non-shared library's contents is actually essential, libpq.a would be
> useless anyway

I don't think that the primary purpose of tsort/lorder is to produce a
functioning library. The idea is to reduce the link time when the
library is later used by reducing the number of passes that the link
editor has to make over the input libraries. I doubt this matters much
anymore, and it's certainly not going to help with the sort of
libraries that PostgreSQL produces with circular references all over.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-04-19 23:18:40 Re: [PATCH] Reduce noise from tsort
Previous Message Tom Lane 2006-04-19 16:34:00 Re: [PATCH] Reduce noise from tsort