| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: foreign_data test fails with non-C locale |
| Date: | 2009-01-09 15:21:46 |
| Message-ID: | 49676B8A.8020707@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> Andrew Dunstan wrote:
>> Regression tests have always failed on non-C locales AFAIK. The
>> buildfarm goes out of its way to avoid that.
>
> The regression tests should work just fine in non-C locales. If the
> buildfarm goes out of its way to avoid non-C locales, then it loses
> some significant code coverage, considering that there are several
> variant code paths for locales, and considering the amount of users
> that use them.
It was discussed here at the time, IIRC, and we put in the check
precisely because other locales broke the buildfarm. Originally
buildfarm just inherited the locale from its environment.
If it is no longer true that other locales break the tests, then I'm
happy to examine alternatives.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hiroshi Saito | 2009-01-09 15:57:08 | Re: Solve a problem of LC_TIME of windows. |
| Previous Message | Heikki Linnakangas | 2009-01-09 15:11:05 | Re: SET TRANSACTION and SQL Standard |