Re: [BUGS] BUG #4186: set lc_messages does not work

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Thomas H(dot)" <me(at)alternize(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, Gevik Babakhani <pgdev(at)xs4all(dot)nl>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: [BUGS] BUG #4186: set lc_messages does not work
Date: 2009-01-07 21:26:04
Message-ID: 49651DEC.1030507@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Hiroshi Inoue wrote:
> Magnus Hagander wrote:
>> Hiroshi Inoue wrote:
>>>> AFAICS there are 2 causes.
>>>>
>>>> 1. MSVC version of postgres is using a bad gettext module.
>>>> 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0.
>>>>
>>>> As for 1, we have to use another gettext module. I can provide it
>>>> if requested.
>>
>> Yes, I think that'll be needed. Exactly what is wrong and needs to be
>> changed? (Copying DAve in on this since he builds the MSI)
>>
>> Is it possible to build this one with the same version of MSVC? If it
>> is, then that should remove the need for #2, right?
>
> Maybe so but what I built was gettext-0.17 and the README.woe32 says
>
> This file explains how to create binaries for the mingw
> execution environment.....
> MS Visual C/C++ with "nmake" is no longer supported.
>
> BTW gettext-0.14.4 has both README.mingw and README.woe32. REAME.woe32
> seems to be for MSVC build.

They are so annoying...

Anyway, if they don't support it, we shuldn't try to force it. Let's go
down the path that they will have different ones, and make getenv() and
friends update both.

Do you want to send an updated patch for it, or do you want me to look
at it?

//Magus

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Hiroshi Inoue 2009-01-07 22:03:32 Re: [BUGS] BUG #4186: set lc_messages does not work
Previous Message Hiroshi Inoue 2009-01-07 21:19:25 Re: [BUGS] BUG #4186: set lc_messages does not work

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2009-01-07 21:31:24 Re: Significant oversight in that #include-removal script
Previous Message Bruce Momjian 2009-01-07 21:24:37 Re: Do we still need constraint_exclusion?