Re: pg_start_backup without checkpoint patch (a part of Synch Rep)

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_start_backup without checkpoint patch (a part of Synch Rep)
Date: 2008-12-29 09:08:23
Message-ID: 49589387.6040605@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii Masao wrote:
> Attached is the self-contained patch to skip checkpoint at pg_start_backup.
> This is a part of Synch Rep patches, and was discussed in the following
> thread.
> http://archives.postgresql.org/message-id/3f0b79eb0812240710j7e613f3atfd6b6fc27403546e@mail.gmail.com

I'm not convinced that this is necessary for the replication patch. It
is an orthogonal, new feature, and should be considered for 8.5, IMHO.

> Specifically, pg_start_backup uses the last checkpoint instead of doing a
> new checkpoint if full_page_writes = on since the last checkpoint, which
> guarantees that all the full-pages required for PITR are written.

That assumes that the DBA has kept all the WAL segments that have been
archived since last checkpoint. So this would no longer be safe:

1. rm <archivedir>/*
2. SELECT pg_start_backup();
3. tar cvzf backup.tar.gz <datadir>
4. SELECT pg_stop_backup();

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas 'ads' Scherbaum 2008-12-29 09:54:16 Re: [patch] Reformat permissions in \l+ (like \z does)
Previous Message Jeff Davis 2008-12-29 07:41:14 Re: Review: B-Tree emulation for GIN