| From: | Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: SQL/MED catalog manipulation facilities This doesn't do any |
| Date: | 2008-12-20 15:27:30 |
| Message-ID: | 494D0EE2.4000209@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Heikki Linnakangas wrote:
> The callers of transformGenericOptions-function in foreigncmds.c use
> OidIsValid to check the return value of transformGenericOptions, but it
> returns an array, not an Oid. I committed a fix for that, we'll see if
> it heals the buildfarm.
>
Thanks for that. There was an additional use of the Datum as Oid in
AlterForeignDataWrapper, namely the assignment to repl_vals.
Another bug was uncovered on orca -- a missing semicolon in gram.y:3004
Fixes attached.
regards,
Martin
| Attachment | Content-Type | Size |
|---|---|---|
| sql-med-fix.patch | text/x-diff | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-12-20 15:51:28 | pgsql: Fix various confusions of pointers and OIDs, unsafe assumptions |
| Previous Message | Peter Eisentraut | 2008-12-20 15:27:03 | Re: [COMMITTERS] pgsql: Append major version number and for libraries soname major |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Mielke | 2008-12-20 15:29:16 | Re: Sync Rep: First Thoughts on Code |
| Previous Message | Peter Eisentraut | 2008-12-20 15:27:03 | Re: [COMMITTERS] pgsql: Append major version number and for libraries soname major |