Re: Beginner hacker item: Fix to_reg*() input type

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Petr Korobeinikov <pkorobeinikov(at)gmail(dot)com>
Cc: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Beginner hacker item: Fix to_reg*() input type
Date: 2016-01-05 18:04:03
Message-ID: 4946.1452017043@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Petr Korobeinikov <pkorobeinikov(at)gmail(dot)com> writes:
>> - Modify the functions in regproc.c. Take a look at how other text input
>> functions work to see what needs to happen here (you'll want to use
>> text_to_cstring() as part of that.)
>>
>> - Modify the appropriate entries in src/include/catalog/pg_proc.h

> Let me try.
> `make check` says "All 160 tests passed.".

Pushed, thanks!

(I did make some small adjustments --- in this usage, PG_GETARG_TEXT_PP
is good enough and likely a bit more efficient than PG_GETARG_TEXT_P.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-01-05 18:46:51 pg_conversion seems rather strangely defined
Previous Message Alvaro Herrera 2016-01-05 17:53:56 Re: bootstrap pg_shseclabel in relcache initialization