Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis
Date: 2025-11-17 10:33:26
Message-ID: 493885FB-F88D-4DD5-8146-EAA6B495CA24@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Nov 17, 2025, at 14:48, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>> #2
>> Now renames "all_publication_object" to "publication_all_objects".
>> This is a simple name change that does not affect anything. I felt
>> everything ought to have the prefix of the object it belongs to (e.g.
>> "publication_name", "publication_parameter", "table_name",
>> "schema_name", column_name" all follow this rule, but prefix "all_"
>> was the odd-one-out).
>>
>
> I don’t like this renaming. Or at lease don’t use plural.

I incidentally clicked on “Send” too quick. I’d add a few words on this.

Here, “all_public_object” refers to “ALL TABLES” or “ALL SEQUENCES”. In this context, the thing is “ALL” instead of multiple objects, that’s why I don’t like the renaming, or at lease the new name should not use plural.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Kukushkin 2025-11-17 10:40:09 Re: Issue with logical replication slot during switchover
Previous Message Viktor Holmberg 2025-11-17 10:26:59 Running a single test