Patch : "Change the panel in tabs was setting the top switches to SQL Editor"

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Patch : "Change the panel in tabs was setting the top switches to SQL Editor"
Date: 2008-12-04 10:36:46
Message-ID: 4937B2BE.9010001@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave Page,
> I think - this is a bug from a while, I can reproduce the same for the
> "Criteria Panel".
> If I make any changes in the "Criteria Panel", and then click "Columns
> Panel", the main
> tab set at the top switches to "SQL Editor". :(
>
> I will send a patch for it.
As I have told you, this was a bug introduced earlier.
The object sqlNoteBook (in frmQuery class) and the object tabs (in the
gqbController class)
both were using the same id (CTL_NTBKCENTER).
And in frmQuery class, an event handler - OnChangeNotebook is registered
with this id.

I changed the id for the object tabs of gqbController to CTL_NTBKPANELS.

Please find the patch for the same.

Regards,
Ashesh

Attachment Content-Type Size
tabsChangeEventBeharior.patch text/x-patch 930 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message svn 2008-12-04 11:01:25 SVN Commit by dpage: r7507 - in trunk/pgadmin3/pgadmin: . gqb include/gqb include/images
Previous Message Ashesh Vashi 2008-12-04 10:21:33 Re: Patch for "Panel for Joins in the Graphic Query Builder"