Re: Patch for "Panel for Joins in the Graphic Query Builder"

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch for "Panel for Joins in the Graphic Query Builder"
Date: 2008-12-04 10:21:33
Message-ID: 4937AF2D.7010108@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find the updated patch.
>> That sounds good. It seems to work for a while, and then the row
>> highlighting stops working. It seemed to stop after I clicked on (but
>> didn't change the value) in one of the combos in the Join Type column.
>> To get it to work again, I have to close and re-open the query tool.
>>
>
> That is still broken however. Basically, clicking on a join just stops
> highlighting the appropriate row. Double-clicking doesn't highlight
> either, but it does still change the tab.
>
This was happening, because I completely missed to call the
gqbCustomGrid's Revert function.

Regards,
Ashesh

Attachment Content-Type Size
GQBJoinsPanel_v4.patch text/x-patch 47.4 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2008-12-04 10:36:46 Patch : "Change the panel in tabs was setting the top switches to SQL Editor"
Previous Message Dave Page 2008-12-03 15:59:24 Re: Patch for "Panel for Joins in the Graphic Query Builder"