Erroring out on parser conflicts

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Erroring out on parser conflicts
Date: 2008-11-25 09:52:26
Message-ID: 492BCADA.8020902@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

While hacking on parser/gram.y just now I noticed in passing that the
automatically generated ecpg parser had 402 shift/reduce conflicts.
(Don't panic, the parser in CVS is fine.) If you don't pay very close
attention, it is easy to miss this. Considering also that we frequently
have to educate contributors that parser conflicts are not acceptable,
should we try to error out if we see conflicts?

Something like this could work:

$(srcdir)/preproc.c: $(srcdir)/preproc.y
$(BISON) -d $(BISONFLAGS) -o $@ $< 2>preproc.stderr
cat preproc.stderr
[ ! -s preproc.stderr ]

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Martin Pihlak 2008-11-25 10:10:13 Re: SQL/MED compatible connection manager
Previous Message Pavan Deolasee 2008-11-25 09:26:11 Re: Review: Hot standby