Re: [COMMITTERS] pgsql: TABLE command

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: TABLE command
Date: 2008-11-21 11:24:12
Message-ID: 49269A5C.5030706@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> petere(at)postgresql(dot)org (Peter Eisentraut) writes:
>> Log Message:
>> -----------
>> TABLE command
>
> If this got re-posted for review I missed it :-(. I disagree with using
> qualified_name here --- I think it would be better to use relation_expr
> so that people would have the ability to specify inheritance behavior.
> If you want to point to the spec and say that that syntax isn't in the
> spec, that's true, but then you need to justify the inhOpt setting
> you're forcing people to use. It's not entirely clear what behavior the
> spec intends, but I'm pretty sure INH_DEFAULT isn't it.

relation_expr is fine by me. It just makes the syntax more complicated
to explain ...

Btw., so we plan to keep the sql_inheritance parameter forever?

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2008-11-21 11:47:55 pgsql: Use relation_expr for TABLE command, requested by Tom.
Previous Message User Yibo1976 2008-11-21 03:26:48 pgexternaltable - src: fix a bug about memory leak when config bad file

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavan Deolasee 2008-11-21 11:38:53 Re: Hot Standby (commit fest version - v5)
Previous Message KaiGai Kohei 2008-11-21 10:47:04 Re: Updates of SE-PostgreSQL 8.4devel patches (r1197)