Re: Re: [COMMITTERS] pgsql: Silence compiler warning about ignored return value.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Silence compiler warning about ignored return value.
Date: 2008-11-20 21:27:13
Message-ID: 4925D631.5050302@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Magnus Hagander wrote:
> Tom Lane wrote:
>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>> Tom Lane wrote:
>>>> We're definitely *not* fortify-clean, although maybe trying to become so
>>>> would be a good idea. From memory, what I have seen in past builds on
>>>> Red Hat systems is a lot of warnings about ignoring the return value
>>>> from fwrite() and related functions.
>>> So. Should I revert it?
>> I dunno. Was that the only such warning you got on your build? That
>> would be a bit odd given that I see many more ...
>
> Yeah, it happens in more places. I wasn't doing a make clean first, so
> that was the only one of the files that were built *that time* that gave
> the warning. I see it in more places now.
>
> I think I'll go figure out how to turn fortify off :-)

Actually, better not. That's what caught that string format bug after all...

//Magnus

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-11-20 22:26:23 Re: pgsql: TABLE command
Previous Message Magnus Hagander 2008-11-20 21:26:02 Re: Re: [COMMITTERS] pgsql: Silence compiler warning about ignored return value.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-11-20 21:30:51 Re: Autoconf, libpq and replacement function
Previous Message Magnus Hagander 2008-11-20 21:26:02 Re: Re: [COMMITTERS] pgsql: Silence compiler warning about ignored return value.