Re: Autoconf, libpq and replacement function

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Autoconf, libpq and replacement function
Date: 2008-11-20 21:02:43
Message-ID: 4925D073.5030705@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>> Also, judging from the comments in the autoconf manual, you'd better
>>> use AC_FUNC_FNMATCH not just test whether the function exists.
>
>> Ok, will look at switching to that.
>
> Hmm ... actually there's still possibly an issue there: what if the
> system provides a broken version of fnmatch? AC_FUNC_FNMATCH will not
> set HAVE_FNMATCH, and then we might end up with #define conflicts
> anyway.
>
> Since fnmatch and the #define's are supposed to be provided by
> <fnmatch.h>, I think you should probably put the substitute definitions
> in a substitute fnmatch.h, not port.h, to avoid that risk.

Do we have an example where we do that before? I assume there is some
autoconfy way to make that include file only "appear" in the include
path if the system one doesn't exist or is broken?

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-11-20 21:05:45 Re: Autoconf, libpq and replacement function
Previous Message Tom Lane 2008-11-20 21:00:25 Re: Autoconf, libpq and replacement function