Re: Block-level CRC checks

From: "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>
To: Aidan Van Dyk <aidan(at)highrise(dot)ca>
Cc: Greg Stark <greg(dot)stark(at)enterprisedb(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Gregory Stark <stark(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Block-level CRC checks
Date: 2008-11-17 20:02:32
Message-ID: 4921CDD8.8090204@zeut.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Aidan Van Dyk wrote:
> * Greg Stark <greg(dot)stark(at)enterprisedb(dot)com> [081117 03:54]:
>> I thought of saying that too but it doesn't really solve the problem.
>> Think of what happens if someone sets a hint bit on a dirty page.
>
> If the page is dirty from a "real change", then it has a WAL backup block
> record already, so the torn-page on disk is going to be fixed with the wal
> replay ... *because* of the torn-page problem already being "solved" in PG.
> You don't get the hint-bits back, but that's no different from the current
> state. But nobody's previously cared if hint-bits wern't set on WAL replay.

What if all changes to a page (even hit bits) are WAL logged when
running with Block-level CRC checks enables, does that make things
easier? I'm sure it would result in some performance loss, but anyone
enabling Block Level CRCs is already trading some performance for safety.

Thoughts?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2008-11-17 20:18:39 Re: xmlconcat as variadic function
Previous Message Merlin Moncure 2008-11-17 19:24:46 Re: Compiling on HP-UX 10.20 fails