Re: [PATCHES] odd output in restore mode

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Martin Zaun <Martin(dot)Zaun(at)Sun(dot)COM>, Greg Smith <gsmith(at)gregsmith(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Dave Page <dpage(at)pgadmin(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] odd output in restore mode
Date: 2008-11-11 23:09:09
Message-ID: 491A1095.1030706@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


I have a fairly large TODO list, and Simon has thrown in the towel (and
I imagine he also has a large TODO list).

anyone else want to step in?

cheers

andrew

Bruce Momjian wrote:
> Have we made any progress on this, namely better documentation and
> removing the Win32 delay code?
>
> ---------------------------------------------------------------------------
>
> Andrew Dunstan wrote:
>
>> Simon Riggs wrote:
>>
>>> Well, this is a strange conclusion, leaving me slightly bemused.
>>>
>>> The discussion between Andrew and I at PGcon concluded that we would
>>> * document which other tools to use
>>> * remove the delay
>>>
>>> Now we have rejected the patch which does that, but then re-requested
>>> the exact same thing again.
>>>
>>> The patch interprets "remove the delay" as "remove the delay in a way
>>> which will not screw up existing users of pg_standby when they upgrade".
>>> Doing that requires us to have a configurable delay, which defaults to
>>> the current behaviour, but that can be set to zero (the recommended
>>> way). Which is what the patch implements.
>>>
>>> Andrew, Heikki: ISTM its time to just make the changes yourselves. This
>>> is just going round and round to no benefit. This doesn't warrant such a
>>> long discussion and review process.
>>>
>>>
>> You ought to know by now that the length and ferocity of the discussion
>> bears no relation at all to the importance of the subject ;-)
>>
>> Personally, I think it's reasonable to provide the delay as long as it's
>> switchable, although I would have preferred zero to be the default. If
>> we remove it altogether then we force bigger changes on people who are
>> currently using Windows copy. But I can live with that since changing
>> their archive_command is the better path by far anyway, either to use
>> Gnu cp or the copy / rename trick.
>>
>> cheers
>>
>> andrew
>>
>>
>
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2008-11-11 23:16:54 Re: Optimizing COPY
Previous Message Bruce Momjian 2008-11-11 22:24:41 Re: [PATCHES] odd output in restore mode

Browse pgsql-patches by date

  From Date Subject
Next Message Hiroshi Saito 2008-11-16 13:36:50 Re: [PATCHES] Solve a problem of LC_TIME of windows.
Previous Message Bruce Momjian 2008-11-11 22:24:41 Re: [PATCHES] odd output in restore mode