Re: gram.y=>preproc.y

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, PostgreSQL Hacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: gram.y=>preproc.y
Date: 2008-11-10 20:49:26
Message-ID: 49189E56.1050801@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Michael Meskes <meskes(at)postgresql(dot)org> writes:
>> Also included is a perl version of the script created by a2p
>> and fixed by me. Unfortunately a2p did not generate working code, so I guess
>> eventually we have to only work with the perl version. I guess a perl hacker
>> can beautify the script quite a bit.
>
> We should probably standardize on the perl version, ugly or not, because
> otherwise we'll have a difference in build process between Unix and
> Windows machines. Personally I don't really care how ugly it is as long
> as no one has to look at it ;-) ... but if someone wants to beautify the
> perl script they're surely welcome to do so.

+1.

> A few notes:
>
> * before committing we need to see the proposed diffs to the Makefiles
> and the Windows build scripts.

It might be worthwhile to make it as a perl module, called from the
commandline in Unix and just included directly in the win32 build
scripts. But someone more perly can comment on if that's a prettier way
or not:-)

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2008-11-10 20:54:27 Re: SQL5 budget
Previous Message David Rowley 2008-11-10 20:48:23 Re: SQL5 budget