| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: plperl needs upgrade for Fedora 10 |
| Date: | 2008-11-06 17:56:35 |
| Message-ID: | 49132FD3.2010904@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> I'm thinking of something like this change to config/perl.m4:
>>
>
>
>> ! if test -z "$perl_embed_ldflags" ; then
>> ! AC_MSG_RESULT(no)
>> ! AC_MSG_ERROR([unable to determine flags to link embedded Perl])
>>
>
> Hm, is it certain that "empty" is never a valid value for
> $perl_embed_ldflags?
Yes. If it's empty we don't even link against libperl at all. That can't
possibly be right.
> In any case I'm a bit confused how this fixes the
> problem --- it looks like the test is just relying on Config not Embed.
>
>
>
No, we get the ldopts from Embed and then *remove* the ccldflags from
Config from that string. What is left is set as perl_embed_flags, and
that's what mustn't be empty.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-11-06 17:58:42 | Re: Hot standby v5 patch assertion failure |
| Previous Message | Tom Lane | 2008-11-06 17:51:44 | Re: My review for the patch "Table command" |