| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Unite ReadBufferWithFork, ReadBufferWithStrategy, and |
| Date: | 2008-11-04 15:55:04 |
| Message-ID: | 49107058.6060905@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera wrote:
> Hmm. I see that some messages are now like this:
>
> (errmsg("unexpected data beyond EOF in block %u of relation %u/%u/%u/%u",
> blockNum, smgr->smgr_rnode.spcNode, smgr->smgr_rnode.dbNode, smgr->smgr_rnode.relNode, forkNum),
>
> but it seems that the file names contain symbolic fork names, not
> numbers. Is it possible to build the error messages so that they report
> the actual file name, or at least change the last /%u into a _%s with
> the fork name?
Agreed. There was some messages like that before, this patch just
changed some error messages I had missed before. I'll change them all to
match the file names ("%u/%u/%u_%s").
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2008-11-04 20:58:46 | pgsql: Remove unused rfno from PLpgSQL_recfield Jonah Harris |
| Previous Message | User H-saito | 2008-11-04 15:48:48 | psqlodbc - psqlodbc: Fixed Soalris compiller error. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2008-11-04 15:57:40 | Re: Patch for SQL-Standard Interval output and decouplingDateStyle from IntervalStyle |
| Previous Message | Heikki Linnakangas | 2008-11-04 15:51:41 | Re: Synchronous replication patch v1 |