Re: CI: Add task that runs pgindent

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> Conforming to indentation rules in v1 of a patchset isn't the most interesting
> aspect of a submission, especially for WIP and POC style patches.

I have a more concrete argument: sometimes, it's helpful to submit
an un-pgindent'd patch because correct indentation will require
reindenting a large amount of existing code (because of addition or
removal of a layer of braces). Showing the effects of that in a
patch meant for review only makes the reviewer's life harder.
So I think there is plenty of room for workflows where the committer
is expected to reindent just before commit.

That's not to say that it couldn't be helpful for CI to point out
the need for indent. It's just to say that the test mustn't get
set up so that other tests don't run, or so that it looks like
there is any severe problem. That leads me to think it ought to be
a separate task.

regards, tom lane