| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Kenneth Marshall <ktm(at)rice(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndQuadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, Michael Glaesemann <grzm(at)seespotcode(dot)net>, David Fetter <david(at)fetter(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: minimal update |
| Date: | 2008-10-29 19:48:09 |
| Message-ID: | 4908BDF9.8020205@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> Andrew Dunstan escribió:
>
>
>> + /* make sure it's called as a trigger */
>> + if (!CALLED_AS_TRIGGER(fcinfo))
>> + elog(ERROR, "suppress_redundant_updates_trigger: must be called as trigger");
>>
>
> Shouldn't these all be ereport()?
>
>
Good point.
I'll fix them.
Maybe we should fix our C sample trigger, from which this was taken.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2008-10-29 19:49:39 | Re: PostgreSQL network discovery |
| Previous Message | Magnus Hagander | 2008-10-29 19:47:23 | Re: PostgreSQL network discovery |