Re: [PATCH] Memory leak in pg_config

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Raúl Marín Rodríguez <rmrodriguez(at)carto(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Memory leak in pg_config
Date: 2018-11-14 15:22:37
Message-ID: 48f9b357-566f-25a1-db60-5bcbe52afdfb@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/14/18 3:59 PM, Tom Lane wrote:
> =?UTF-8?B?UmHDumwgTWFyw61uIFJvZHLDrWd1ZXo=?= <rmrodriguez(at)carto(dot)com> writes:
>> I've been trying to run Postgis regress tests under Clang sanitizers and one of
>> the issues I'm facing is the constant stream of errors during the `configure`
>> step coming from calls to `pg_config`.
>
> TBH, I do not think we should do anything about this. It has never been
> project policy that short-lived programs should free everything before
> exiting, and I don't think we should change that. initdb, in particular,
> would need a huge amount of work to meet such a policy, and it would
> really be entirely wasted effort. Just because you've configured your
> tools to enforce an unreasonable policy doesn't make it a reasonable one.
>

Yeah. Incidentally we had the same discussion about initdb a few days
ago [1], and the conclusion was pretty much exactly the same.

[1]
https://www.postgresql.org/message-id/flat/3fe1e38a-fb70-6260-9300-ce67ede21c32%40redhat.com

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-11-14 15:25:03 Re: DSM segment handle generation in background workers
Previous Message Evgeniy Efimkin 2018-11-14 15:10:46 Re: [WIP] Special role for subscriptions