Re: DISTINCT term in aggregate function

Sorry, I'm not reading pgsql-docs very often, so I missed the post.
Yeah, we should probably add an indexterm to the other places too.

regards

On 3/18/21 7:03 PM, Pantelis Theodosiou wrote:
> Hi, I didn't think of including you in this suggestion.
> Or the pdsql-docs was not the right list to post? I didn't want to mix
> it with the GROUP BY DISTINCT patch.
>
> Please check my suggestion.
>
> Best regards
> Pantelis Theodosiou
>
>
>
>
> ---------- Forwarded message ---------
> From: *Pantelis Theodosiou* <ypercube(at)gmail(dot)com <mailto:ypercube(at)gmail(dot)com>>
> Date: Sat, Mar 13, 2021 at 1:03 AM
> Subject: Fwd: GROUP BY DISTINCT
> To: <pgsql-docs(at)lists(dot)postgresql(dot)org
> <mailto:pgsql-docs(at)lists(dot)postgresql(dot)org>>
>
>
>
> ---------- Forwarded message ---------
> From: *Tomas Vondra* <tomas(dot)vondra(at)enterprisedb(dot)com
> <mailto:tomas(dot)vondra(at)enterprisedb(dot)com>>
> Date: Fri, Mar 12, 2021 at 11:33 PM
> Subject: Re: GROUP BY DISTINCT
> To: Vik Fearing <vik(at)postgresfriends(dot)org
> <mailto:vik(at)postgresfriends(dot)org>>, Georgios Kokolatos
> <gkokolatos(at)protonmail(dot)com <mailto:gkokolatos(at)protonmail(dot)com>>,
> <pgsql-hackers(at)lists(dot)postgresql(dot)org
> <mailto:pgsql-hackers(at)lists(dot)postgresql(dot)org>>
> Cc: Erik Rijkers <er(at)xs4all(dot)nl <mailto:er(at)xs4all(dot)nl>>
>
>
> Hi Vik,
>
> The patch seems quite ready, I have just two comments.
>
> 1) Shouldn't this add another <indexterm> for DISTINCT, somewhere in the
> documentation? Now the index points just to the SELECT DISTINCT part.
>
> .....
>
> regards
>
> --
> Tomas Vondra
> EnterpriseDB: http://www.enterprisedb.com <http://www.enterprisedb.com>
> The Enterprise PostgreSQL Company
>
>
>
> After reading the above thread in hackers, I noticed that the index does
> not point to aggrgeate functions either and DISTINCT is not mentioned in
> the aggregate functions page
> either: https://www.postgresql.org/docs/current/functions-aggregate.html
> <https://www.postgresql.org/docs/current/functions-aggregate.html>
> Shouldn't it be mentioned with an example of COUNT(DISTINCT ...)  or
> aggregate_function(DISTINCT ...) in general ?
>
> Best regards
>
> Pantelis Theodosiou

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company