| From: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: memory leak in trigger handling (since PG12) |
| Date: | 2023-06-23 06:03:24 |
| Message-ID: | 48e251869b7ef921b7f894a3c7cb154a@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tomas Vondra писал 2023-06-22 17:16:
> On 6/22/23 13:46, Tomas Vondra wrote:
>> ...
>>
>> I haven't tried the reproducer, but I think I see the issue - we store
>> the bitmap as part of the event to be executed later, but the bitmap
>> is
>> in per-tuple context and gets reset. So I guess we need to copy it
>> into
>> the proper long-lived context (e.g. AfterTriggerEvents).
>>
>> I'll get that fixed.
>>
>
> Alexander, can you try if this fixes the issue for you?
>
>
> regard
Hi.
The patch fixes the problem and looks good to me.
--
Best regards,
Alexander Pyhalov,
Postgres Professional
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2023-06-23 06:40:34 | Re: Do we want a hashset type? |
| Previous Message | Noah Misch | 2023-06-23 05:29:12 | Re: vac_truncate_clog()'s bogus check leads to bogusness |