| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: FSM rewrite: doc changes |
| Date: | 2008-09-30 07:23:22 |
| Message-ID: | 48E1D3EA.10501@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>> Tom Lane wrote:
>>> In fsm_rebuild_page, surely we needn't check "if (lchild < NodesPerPage)".
>
>> Yes, we do.
>
> But the loop starting point is such that you must be visiting a parent
> with at least one child, no?
Hmm, true, and that means that the comment above it is wrong. I'll
change the code to do what the comment says. That way, if the page is
completely garbled, and a parent node with no children has a value other
than zero, that gets fixed too.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Abbas | 2008-09-30 07:39:43 | Re: [REVIEW] Prototype: In-place upgrade v02 |
| Previous Message | Zdenek Kotala | 2008-09-30 07:08:14 | Re: [REVIEW] Prototype: In-place upgrade v02 |