| From: | Andrew Chernow <ac(at)esilo(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Merlin Moncure <mmoncure(at)gmail(dot)com> |
| Subject: | Re: [PATCHES] libpq events patch (with sgml docs) |
| Date: | 2008-09-19 18:14:04 |
| Message-ID: | 48D3EBEC.1040503@esilo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
>
> I'll go ahead and apply this patch in a little bit, but if you concur
> with the above reasoning, please put together a followon patch to add
> such a function.
>
> regards, tom lane
>
>
I attached a patch. You have to copy the events in PQmakeEmptyPGResult
because there is no where else to do this, other than copyresult but
that is different because it copies from a result not a conn.
PQmakeEmptyPGResult - must copy events here
PQsetResultAttrs - set attributes
PQsetvalue - set tuple values
PQfireResultCreateEvents(conn,res) - now fire resultcreate event
PQgetResult now calls PQfireResultCreateEvents.
BTW, the event system might be an alternative solution for PGNoticeHooks
(PGEVT_NOTICE).
--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| pgevents.patch | text/plain | 7.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Treat | 2008-09-19 18:28:01 | Re: Where to Host Project |
| Previous Message | Joshua Drake | 2008-09-19 18:12:21 | Re: Where to Host Project |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2008-09-19 18:39:27 | Re: [PATCHES] libpq events patch (with sgml docs) |
| Previous Message | Tom Lane | 2008-09-19 16:11:02 | Re: [PATCHES] libpq events patch (with sgml docs) |