| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Simon Riggs <simon(at)2ndQuadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: optimizing CleanupTempFiles |
| Date: | 2008-09-18 12:17:18 |
| Message-ID: | 48D246CE.1010104@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>> Looks like we didn't make an
>> exception for temporary tables. Although it's harmless, we could put an
>> isTempOrToastNamespace() test in there:
>
> Bad, bad idea to have md.c doing any catalog access.
isTempOrToastNamespace() doesn't access catalogs, it's just checking the
argument against two global variables. I guess you could argue that it's
a modularity violation.
> As already noted downthread, it wouldn't buy much anyway.
Yeah. *shrug*
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-09-18 12:18:00 | Re: [PATCHES] Infrastructure changes for recovery |
| Previous Message | Simon Riggs | 2008-09-18 12:09:03 | Re: Adding new flags to XLogRecord |