| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: optimizing CleanupTempFiles |
| Date: | 2008-09-18 09:56:41 |
| Message-ID: | 48D225D9.1010502@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs wrote:
> On Thu, 2008-09-18 at 10:19 +0300, Heikki Linnakangas wrote:
>> Simon Riggs wrote:
>>> An unfortunate choice of words! Harmless is not how your average DBA
>>> would describe it when their disk fills and they are apparently unable
>>> to reduce space consumption. So there is still a problem there even if
>>> we fix the temp files portion of it.
>> The files *are* truncated to zero bytes immediately. They're left
>> hanging as empty files until next checkpoint.
>
> Ah, cool. So won't actually unlinking temp files be slower than just
> leaving them for checkpointer to clear up offline? i.e. do we really
> need the patch you just posted?
Dunno, maybe. I doubt it's significant either way.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zdenek Kotala | 2008-09-18 10:17:42 | Re: [REVIEW] Prototype: In-place upgrade v02 |
| Previous Message | Heikki Linnakangas | 2008-09-18 09:41:59 | Re: EncodeDateTime performance |