| From: | Andrew Chernow <ac(at)esilo(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Merlin Moncure <mmoncure(at)gmail(dot)com> |
| Subject: | Re: [PATCHES] libpq events patch (with sgml docs) |
| Date: | 2008-09-17 14:29:23 |
| Message-ID: | 48D11443.4010608@esilo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
New patch following our discussion with updated docs.
>> few logical errors). I don't think it makes sense to do it otherwise,
>> it would be like calling free after a malloc failure.
>
> I can live with that definition, but please document it.
>
>
To build on this analogy, PGEVT_CONNRESET is like a realloc. Meaning,
the initial malloc "PGEVT_REGISTER" worked by the realloc
"PGEVT_CONNRESET" didn't ... you still have free "PGEVT_CONNDESTROY" the
initial. Its documented that way. Basically if a register succeeds, a
destroy will always be sent regardless of what happens with a reset.
--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| libpq-events.patch | text/plain | 51.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2008-09-17 14:30:47 | Re: New FSM patch |
| Previous Message | Alvaro Herrera | 2008-09-17 14:22:28 | Re: Autovacuum and Autoanalyze |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Chernow | 2008-09-17 14:37:37 | Re: [PATCHES] libpq events patch (with sgml docs) |
| Previous Message | Tom Lane | 2008-09-17 13:36:26 | Re: [PATCHES] libpq events patch (with sgml docs) |