Re: [PATCHES] libpq events patch (with sgml docs)

Alvaro Herrera wrote:
> Andrew Chernow escribió:
>
>> * and the Perl5 interface, so maybe it's not so unreasonable.
>> + *
>> + * Updated April 2008 - If conn is not NULL, event states will be copied
>> + * from the PGconn to the created PGresult.
>> */
>
> Don't do this either. We don't really need to know when the thing was
>

Changed that and made it one paragraph.

>> + /* resultalloc the attribute names. The above memcpy has the attr
>> + * names pointing at the callers provided attDescs memory.
>> + */
>
> "resultalloc"? Why not just "allocate"?
>

Because resultalloc is what a PGresult uses to allocate its attribute
names (See line 513 of fe-protocol3.c). Also, PQclear frees its memory
blocks, not individual items like attname.

>> * PQclear -
>> * free's the memory associated with a PGresult
>> */
>
> I'd add a comment here stating why the event name is not deallocated;
> otherwise it just looks like it's being leaked.
>
>

The event name is being deallocated.

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/