Re: [PATCHES] libpq events patch (with sgml docs)

Alvaro Herrera wrote:
> Andrew Chernow escribió:
>
>> ! printfPQExpBuffer(&conn->errorMessage,
>> ! libpq_gettext("PGEventProc \"%s\" failed during PGEVT_CONNRESET event\n"),
>> ! conn->events[i].name);
>> ! else
>> ! printfPQExpBuffer(&conn->errorMessage,
>> ! libpq_gettext("PGEventProc \"addr:%p\" failed during PGEVT_CONNRESET event\n"),
>> ! conn->events[i].proc);
>> ! break;
>
> Please don't do this. It creates extra unnecessary work for
> translators. Better create a local var, assign either "name" or
> "addr:<value>" to it, and then use that in the message.
>
> (For the record, I'd prefer that the name is made mandatory.)
>

The name is now mandatory, no need to toggle the format string anymore.

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/