libpq events update

From: Andrew Chernow <ac(at)esilo(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: libpq events update
Date: 2008-09-05 13:49:21
Message-ID: 48C138E1.4010003@esilo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I would like to remove the PQpassThroughData and PQresultPassThroughData
functions. The passThrough pointer should be added as a 3rd argument
to the PGEventProc:

typedef int (*PGEventProc)(PGEventId evtId, void *evtInfo,
void *passThrough);

Having a public accessor function for the passThrough. doesn't seem
helpful. Its purpose is to be available to the eventproc, which doesn't
require a public function.

I think it got confused with the instanceData feature, which has nothing
to do with the event system and requires public functions. libpqtypes
happens to use the instanceData functions within its eventproc, but this
is not a requirement.

All those who oppose any of the above, speak now or forever hold your
peace. An updated patch with full sgml documentation is coming.

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Sabino Mullane 2008-09-05 13:53:44 Re: Need more reviewers!
Previous Message Peter Eisentraut 2008-09-05 13:40:32 Re: pg_regress inputdir