Re: First public pre-alpha release of GQB (Graphical Query Builder) for pgAdmin

Hi,

Luis Ochoa a écrit :
> I have been working on improve my Google Summer of Code Project:
> http://wiki.postgresql.org/wiki/Gsoc08-querybuilder for a while, and
> today I'm going to release what I believe it's the first public
> pre-alpha release, as you notice this release is for testing only an
> i'ts provided with no warranty :)
>

First, the patch doesn't apply cleanly :

patching file pgadmin/include/frm/frmQuery.h
Hunk #2 FAILED at 19.
1 out of 6 hunks FAILED -- saving rejects to file
pgadmin/include/frm/frmQuery.h.rej

and

patching file pgadmin/pgAdmin3.vcproj
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 2317.
Hunk #3 FAILED at 3042.
3 out of 3 hunks FAILED -- saving rejects to file
pgadmin/pgAdmin3.vcproj.rej

Then, it didn't build as is. I had to modify
pgadmin/include/gqb/gqbViewController.h because of:

../pgadmin/include/gqb/gqbViewController.h:60: erreur: extra
qualification «gqbController::» on member «addRestriction»

I also had this issue:

gqbViewPanels.o: In function `wxGridCellComboBoxRenderer':

/home/guillaume/freeprojects/svn.pgadmin.org/trunk/pgadmin3.gsoc2/pgadmin/../pgadmin/include/gqb/gqbRestGridTable.h:56:
undefined reference to `vtable for wxGridCellComboBoxRenderer'

gqbViewPanels.o: In function `wxGridCellButtonRenderer':

/home/guillaume/freeprojects/svn.pgadmin.org/trunk/pgadmin3.gsoc2/pgadmin/../pgadmin/include/gqb/gqbRestGridTable.h:73:
undefined reference to `vtable for wxGridCellButtonRenderer'

gqbView.o: In function `gqbView':

/home/guillaume/freeprojects/svn.pgadmin.org/trunk/pgadmin3.gsoc2/pgadmin/./gqb/gqbView.cpp:65:
undefined reference to
`gqbRestGridTable::gqbRestGridTable(gqbRestrictions*)'

/home/guillaume/freeprojects/svn.pgadmin.org/trunk/pgadmin3.gsoc2/pgadmin/./gqb/gqbView.cpp:65:
undefined reference to
`gqbRestGridTable::gqbRestGridTable(gqbRestrictions*)'

It means you forgot this line
$(srcdir)/gqb/gqbRestGridTable.cpp \
in pgadmin/gqb/module.mk file.

So I added this line and I got the following error messages:
./gqb/gqbRestGridTable.cpp: In member function «virtual void
wxFastComboEditor::BeginEdit(int, int, wxGrid*)»:
./gqb/gqbRestGridTable.cpp:438: erreur: «GtkCombo» was not declared in
this scope
./gqb/gqbRestGridTable.cpp:438: erreur: «combo» was not declared in this
scope
./gqb/gqbRestGridTable.cpp:438: erreur: «GTK_COMBO» was not declared in
this scope
./gqb/gqbRestGridTable.cpp:441: erreur: «GdkEventButton» was not
declared in this scope
./gqb/gqbRestGridTable.cpp:441: erreur: expected `;' before «event»
./gqb/gqbRestGridTable.cpp:442: erreur: «event» was not declared in this
scope
./gqb/gqbRestGridTable.cpp:443: erreur: invalid use of incomplete type
«struct _GtkWidget»
/opt/wxgtk-2.8/include/wx-2.8/wx/defs.h:2806: erreur: forward
declaration of «struct _GtkWidget»
./gqb/gqbRestGridTable.cpp:443: erreur: «gdk_window_ref» was not
declared in this scope
./gqb/gqbRestGridTable.cpp:449: erreur: «GDK_CORE_POINTER» was not
declared in this scope
./gqb/gqbRestGridTable.cpp:450: erreur: «GDK_BUTTON_PRESS» was not
declared in this scope
./gqb/gqbRestGridTable.cpp:451: erreur: «GDK_SOURCE_MOUSE» was not
declared in this scope
./gqb/gqbRestGridTable.cpp:453: erreur: invalid use of incomplete type
«struct _GtkWidget»
/opt/wxgtk-2.8/include/wx-2.8/wx/defs.h:2806: erreur: forward
declaration of «struct _GtkWidget»
./gqb/gqbRestGridTable.cpp:456: erreur: «GdkEvent» was not declared in
this scope
./gqb/gqbRestGridTable.cpp:456: erreur: expected primary-expression
before «)» token
./gqb/gqbRestGridTable.cpp:456: erreur: «gtk_widget_event» was not
declared in this scope
./gqb/gqbRestGridTable.cpp:457: erreur: invalid use of incomplete type
«struct _GtkWidget»
/opt/wxgtk-2.8/include/wx-2.8/wx/defs.h:2806: erreur: forward
declaration of «struct _GtkWidget»
./gqb/gqbRestGridTable.cpp:457: erreur: «gdk_window_unref» was not
declared in this scope
./gqb/gqbRestGridTable.cpp:458: erreur: «gtk_events_pending» was not
declared in this scope
./gqb/gqbRestGridTable.cpp:459: erreur: «gtk_main_iteration» was not
declared in this scope

Why do you use a GtkCombo instead of the wxComboBox?

Can you provide a fixed patch? Thanks.

Regards.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com