| From: | Greg Burd <greg(at)burd(dot)me> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add tests for Bitmapset |
| Date: | 2025-09-30 09:30:51 |
| Message-ID: | 48833E2B-C6E4-4C3D-A002-87234AF9782F@greg.burd.me |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sep 29 2025, at 8:51 pm, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Sep 30, 2025 at 01:19:05PM +1300, David Rowley wrote:
>> NULL is a valid Bitmapset, so I don't really see the need to check for
>> an empty set before calling bms_free(). If those were removed, then
>> you'd not have to care about the coverage of that line.
Good point, I agree. Thanks for reporting/reviewing David.
> Yeah, we could just remove them as you are suggesting, as well.
> --
> Michael
Thank you both, patch attached.
best.
-greg
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Don-t-check-for-NULL-before-calling-bms_free-in-t.patch | application/octet-stream | 7.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2025-09-30 09:36:26 | Re: Problem with DEB packages |
| Previous Message | Laurenz Albe | 2025-09-30 09:30:50 | Re: pg_restore documentation and --create/--single-transaction limitation |