Re: \d+ should display the storage options for columns

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
Subject: Re: \d+ should display the storage options for columns
Date: 2008-07-15 09:10:37
Message-ID: 487C698D.1060200@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian a écrit :
> Alvaro Herrera wrote:
>> Bruce Momjian wrote:
>>
>>> Update patch applied; I also adjusted some translation function calls.
>>> The new output of psql \d+ is:
>>>
>>> test=> \d+ test
>>> Table "public.test"
>>> Column | Type | Modifiers | Storage | Description
>>> --------+---------+-----------+---------+-------------
>>> x | integer | | plain |
>>> Has OIDs: no
>> Thanks for fixing the header problem.
>>
>> This patch introduces other strings, "plain", "main" and so on that are
>> not gettext_noop()ed. Should we mark those for translation too? I
>> admit I am not sure, if only because the untranslated strings are what
>> gets passed to ALTER TABLE ... SET STORAGE. But if that's the
>> decision, then it oughtta be commented in the code ...
>
> I thought about that, but those strings are literal used in our syntax,
> so translating them seemed wrong.
>

I agree on this. If I had to translate these strings, I would copy the
english string in the french translation. I don't see an advantage on
translating these strings.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2008-07-15 13:55:22 Re: Hint Bits and Write I/O
Previous Message Simon Riggs 2008-07-15 08:31:29 Re: [PATCHES] WIP: executor_hook for pg_stat_statements