| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Don Seiler <don(at)seiler(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Estimating HugePages Requirements? |
| Date: | 2021-08-31 05:37:52 |
| Message-ID: | 48795AC4-289F-4CDE-88F5-4FD1ED2BD3DD@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-admin pgsql-hackers |
On 8/30/21, 12:29 AM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> Attached is a WIP to show how the order of the operations could be
> changed, as that's easier to grasp. Even if we don't do that, having
> the GUC and the refactoring of CalculateShmemSize() would still be
> useful, as one could just query an existing instance for an estimation
> of huge pages for a cloned one.
>
> The GUC shared_memory_size should have GUC_NOT_IN_SAMPLE and
> GUC_DISALLOW_IN_FILE, with some documentation, of course. I added the
> flags to the GUC, not the docs. The code setting up the GUC is not
> good either. It would make sense to just have that in a small wrapper
> of ipci.c, perhaps.
I moved the GUC calculation to ipci.c, adjusted the docs, and added a
huge_pages_required GUC. It's still a little rough around the edges,
and I haven't tested it on Windows, but this seems like the direction
the patch is headed.
Nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Move-the-shared-memory-size-calculation-to-its-ow.patch | application/octet-stream | 7.1 KB |
| v3-0002-Introduce-shared_memory_size-and-huge_pages_requi.patch | application/octet-stream | 12.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Atul Kumar | 2021-08-31 05:45:20 | Re: vacuumlo |
| Previous Message | Laurenz Albe | 2021-08-31 02:57:05 | Re: vacuumlo |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2021-08-31 05:46:42 | Re: Fix around conn_duration in pgbench |
| Previous Message | Shinoda, Noriyoshi (PN Japan FSIP) | 2021-08-31 05:36:47 | Improve logging when using Huge Pages |