| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Michael Banck <michael(dot)banck(at)credativ(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Offline enabling/disabling of data checksums |
| Date: | 2019-03-13 11:43:39 |
| Message-ID: | 487091552477419@myt1-4903e6646a45.qloud-c.yandex.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
>> > Also we support ./configure --with-blocksize=(not equals 8)? make
>> > check on HEAD fails for me. If we support this - i think we need
>> > recheck BLCKSZ between compiled pg_checksum and used in PGDATA
>>
>> You mean if the backend and pg_checksums is built with different
>> blocksize? Yeah, that sounds like something which is a cheap check and
>> should be done.
>
> I've been doing that in my pg_checksums fork for a while (as it further
> removed from the Postgres binaries) but yeah we should check for that as
> well in pg_checksums, see attached patch.
Seems good. And I think we need backpath this check to pg11. similar to cross-version compatibility checks
regards, Sergei
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2019-03-13 11:43:49 | Re: Offline enabling/disabling of data checksums |
| Previous Message | Sergei Kornilov | 2019-03-13 11:40:11 | Re: Offline enabling/disabling of data checksums |