From: | "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> |
---|---|
To: | "Magnus Hagander" <magnus(at)hagander(dot)net> |
Cc: | <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Fix a couple of bugs in win32 shmem name generation: * Don't cut |
Date: | 2008-07-04 12:53:04 |
Message-ID: | 486E1D30.3020705@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander wrote:
> Heikki Linnakangas wrote:
>> Magnus Hagander wrote:
>>> Fix a couple of bugs in win32 shmem name generation:
>>> * Don't cut off the prefix. With this fix, it's again readable.
>>> * Properly store it in the Global namespace as intended.
>>>
>>> Tags:
>>> ----
>>> REL8_3_STABLE
>> What happens if someone launches version 8.3.3 postgres.exe and version
>> 8.3.4 postgres.exe at the same time, on the same data directory? Will
>> the interlock that prevents two postmasters from starting at the same
>> time work?
>
> Hmm. Didn't think of that :(
>
> Yeah, it seems that that part of it would fail. In a lot of cases you'd
> still get kicked off by socket conflicts and such, but the shared memory
> part would not notice someone is already there, no.
Yeah.
> Not sure if it's reason enough to revert - since it fixes other cases. I
> guess in theory we could check both the old and the new name, but that's
> going to be a considerably more complex patch.
Yeah, and it would still fail if you started the new version first, and
then the old one.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2008-07-04 13:21:18 | pgsql: Fix initialization of GinScanEntryData.partialMatch |
Previous Message | Magnus Hagander | 2008-07-04 12:49:31 | Re: pgsql: Fix a couple of bugs in win32 shmem name generation: * Don't cut |
From | Date | Subject | |
---|---|---|---|
Next Message | Bernd Helmle | 2008-07-04 13:18:23 | Re: log_rotation_age integer overflow display quirk |
Previous Message | Magnus Hagander | 2008-07-04 12:49:31 | Re: pgsql: Fix a couple of bugs in win32 shmem name generation: * Don't cut |