Re: Regression test database name

From: Markus Wanner <markus(at)bluegap(dot)ch>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Regression test database name
Date: 2008-07-03 08:32:54
Message-ID: 486C8EB6.9060300@bluegap.ch
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Hi,

Peter Eisentraut wrote:
> For some experiments I wanted to run the regression tests using a different
> database (possibly using pg_regress --dbname=), but the name "regression" is
> hardcoded in a few places. It's trivial to fix, see attached patch. Quick
> explanation: The fact that psql's \z prints the database name has always been
> an inconsistency, so it's good to get rid of anyway. The majority of the
> diff in prepare.out is whitespace differences. Objections?

Looks good from here, passed the regressions on my (pretty standard
debian unstable) box.

However, there were some issues applying the patch, probably related to
git's diff format (patch version 2.5.9):

patch: **** malformed patch at line 255: diff -ur
../cvs-pgsql/src/test/regress/sql/prepare.sql
./src/test/regress/sql/prepare.sql

For those who care, I've added the same patch in context diff format and
modulo whitespaces. :-)

+1 for the change per se.

Regards

Markus

Attachment Content-Type Size
regression-dbname2.diff text/x-diff 5.7 KB

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Pavan Deolasee 2008-07-03 11:50:52 Re: page macros cleanup
Previous Message Marko Kreen 2008-07-03 08:15:10 Re: [PATCHES] pg_dump lock timeout