Small fixes for CHECKPOINT FLUSH_UNLOGGED

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>
Subject: Small fixes for CHECKPOINT FLUSH_UNLOGGED
Date: 2026-05-25 07:07:38
Message-ID: 4855807D-F1CA-44E6-9B58-406691832848@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I just tested “Add FLUSH_UNLOGGED option to CHECKPOINT command”, and found no functional issue. I only noticed a couple of small issues.

1. Tab-completion for FLUSH_UNLOGGED misses its boolean value

FLUSH_UNLOGGED can take a boolean value, but tab completion does not suggest ON/OFF for it. For comparison, REPACK does:
```
evantest=# checkpoint (FLUSH_UNLOGGED o

evantest=# repack (concurrently O
OFF ON
```The fix just follows the existing code for REPACK. After the fix:
```
evantest=# checkpoint (flush_unlogged O
OFF ON
```

2. The CHECKPOINT doc still says “All data files will be flushed to disk”

After introducing FLUSH_UNLOGGED, CHECKPOINT by default no longer flushes dirty buffers of unlogged relations, but checkpoint.sgml still says “All data files will be flushed to disk.” That seems stale, so I updated the doc.

These are two small changes, but to make the patch easier to process, I split them into two commits.

Best reagards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Attachment Content-Type Size
v1-0002-doc-Clarify-CHECKPOINT-handling-of-unlogged-buffe.patch application/octet-stream 1.6 KB
v1-0001-psql-Complete-boolean-values-for-CHECKPOINT-FLUSH.patch application/octet-stream 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message SATYANARAYANA NARLAPURAM 2026-05-25 07:12:34 Re: [PATCH] Release replication slot on error in SQL-callable slot functions
Previous Message jian he 2026-05-25 06:43:56 Re: let ALTER TABLE DROP COLUMN drop whole-row referenced object