Re: [BUGS] BUG #4203: perform dblink() in begin/exception returns wrong SQLSTATE code

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Henry Combrinck <henry(at)zen(dot)co(dot)za>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #4203: perform dblink() in begin/exception returns wrong SQLSTATE code
Date: 2008-06-01 19:03:41
Message-ID: 4842F28D.8070000@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches

Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
>> Tom Lane wrote:
>>> Yeah, the dblink code should probably try a bit harder to propagate the
>>> original error fields.
>
>> Sounds reasonable. Do you think this is a bug fix or an 8.4 enhancement?
>
> 8.4 enhancement I think, since a behavioral change here could pose a
> compatibility issue for applications.
>

Here is my proposed patch -- as suggested for cvs tip only.

I haven't been around enough lately to be sure I understand the process
these days. Should I be posting this to the wiki and waiting for the
next commit fest, or just apply myself in a day or two assuming no
objections?

Thanks,

Joe

Attachment Content-Type Size
dblink.2008.06.01.1.diff text/x-patch 13.1 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2008-06-01 19:37:20 Re: [BUGS] BUG #4203: perform dblink() in begin/exception returns wrong SQLSTATE code
Previous Message Tom Lane 2008-06-01 15:46:22 Re: BUG #4218: PGOPTIONS not documented for psql

Browse pgsql-patches by date

  From Date Subject
Next Message Davy Durham 2008-06-01 19:08:47 Re: Feature: give pg_dump a WHERE clause expression
Previous Message Zdenek Kotala 2008-06-01 19:00:01 Re: partial header cleanup