Re: pg_dump memory leak of 400 bytes

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Oleg Tselebrovskiy <o(dot)tselebrovskiy(at)postgrespro(dot)ru>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump memory leak of 400 bytes
Date: 2024-12-11 10:09:49
Message-ID: 4840A74B-49BD-44C3-91E6-20DAE5A84BB8@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 11 Dec 2024, at 10:59, Oleg Tselebrovskiy <o(dot)tselebrovskiy(at)postgrespro(dot)ru> wrote:

> When I was looking through static analyzer output I've found a memory leak in pg_dump

Thanks for the report, although 400 bytes won't break the bank in the grand
scheme of things considering how much memory pg_dump use there is little point
in not freeing it.

> Patches for both variants are attached. I also propose changing palloc to pg_malloc
> since it is the only place in pg_dump where palloc is used instead of pg_malloc

Freeing it when not needed anymore seems appropriate, I'll go make that happen.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2024-12-11 10:12:36 Re: Logical Replication of sequences
Previous Message Shubham Khanna 2024-12-11 10:05:32 Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility.