Re: BUG #19095: Test if function exit() is used fail when linked static

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: VASUKI M <vasukim1992002(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, BharatDB <bharatdbpg(at)gmail(dot)com>, torsten(dot)rupp(at)gmx(dot)net, pgsql-bugs(at)lists(dot)postgresql(dot)org, byavuz81(at)gmail(dot)com
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
Date: 2025-11-25 10:51:55
Message-ID: 483765ED-0490-4972-9769-4943716BE204@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

> On 25 Nov 2025, at 10:11, VASUKI M <vasukim1992002(at)gmail(dot)com> wrote:

> Thanks for this suggestion michael & Nazir for the code,i have made the changes you said
>
> Also added the check where it scans for nm in the environment if it is not present then it gracefully skips the test.

+if find_program('nm', required: false, native: true).found() and not get_option('b_coverage')
Sorry for being late to the party, but I wonder why we aren't adding this check
to the toplevel meson.build and configure.ac (via config/programs.m4) like how
we check for all others tools used by the build? Such checks should of course
not fail the configuration, merely record the presence or absence of the tool.
The path can then be exported to src/interfaces/libpq/{Makefile|meson.build} to
use.

+open my $fh, '-|', "$nm_path -A -u $input_file 2>/dev/null"
This filehandle is never closed.

+# ---- Skip entirely on Solaris ----
+if ($Config{osname} =~ /solaris/i) {
+ exit 0;
+}
This won't work on Windows either, which wasn't checked for in the Makefile
since make isn't used on Windows.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2025-11-25 11:14:08 Re: ON CONFLICT DO SELECT (take 3)
Previous Message Richard Guo 2025-11-25 10:50:51 Some optimizations for COALESCE expressions during constant folding

Browse pgsql-bugs by date

  From Date Subject
Previous Message Nazir Bilal Yavuz 2025-11-25 10:07:24 Re: BUG #19095: Test if function exit() is used fail when linked static