| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Brendan Jurd <direvus(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Multiline privileges in \z |
| Date: | 2008-05-03 23:57:43 |
| Message-ID: | 481CFBF7.2080701@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Brendan Jurd wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Fri, Apr 18, 2008 at 2:37 AM, Tom Lane wrote:
>
>> The function names in the patch need schema-qualification in case
>> pg_catalog is not first in the search path.
>>
>>
>
> Ah, yes. I should have seen that. Thanks Tom.
>
> New version attached with schema-qualification.
>
Wouldn't this expression:
pg_catalog.array_to_string(c.relacl, chr(10))
be better expressed as
pg_catalog.array_to_string(c.relacl, E'\n')
?
Quoted inside a C literal, the backslash would have to be doubled, of course.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-05-04 00:55:31 | Re: [HACKERS] Multiline privileges in \z |
| Previous Message | Andrew Dunstan | 2008-05-03 23:35:37 | Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-05-04 00:55:31 | Re: [HACKERS] Multiline privileges in \z |
| Previous Message | Andrew Dunstan | 2008-05-03 23:35:37 | Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout |