Re: Behavioral issues in data grid: unsaved data, sort/filter

From: Erwin Brandstetter <brandstetter(at)falter(dot)at>
To: dpage(at)pgadmin(dot)org
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Behavioral issues in data grid: unsaved data, sort/filter
Date: 2008-05-02 23:57:50
Message-ID: 481BAA7E.7080607@falter.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave!

dpage(at)pgadmin(dot)org wrote:
> OK, I've done some playing and uploaded a windows build to
> http://developer.pgadmin.org/~dpage/pgAdmin3.zip (iirc, you usually
> test on Windows). Please give it a whirl - I believe I've fixed the
> <tab> case, but I want to be sure there are no regressions I've missed
> as this seems reasonable to include in 1.8.3.

Right, thanks, I mainly use WinXP as desktop, the transition to Ubuntu
8.04/ Debian Lenny is imminent, though.
Testing pgAdmin v.1.9.0-Dev (May 2 2008), rev: 7245:7266M, on WinXP;
host: pg 8.2.7 and 8.3.1 on Debian Etch.

I have played around a bit and run the same tests as before. AFAICS,
you've nailed all mentioned cases of potential data loss, which is the
most important part.

- <tab> key now seems to have the same effect as moving to the next
field with the mouse pointer. This is a twofold improvement: no data
loss, behavior unified.
The false warnings have consequently become more frequent. It is the
lesser evil, if we have to chose.

- Save warning now fires, if I engage sort/filter, which prevents data loss.
It might be even smarter to wait until sort/filter is actually
applied. If one just wants to look up the filter or decides to [CANCEL]
for any other reason, then we may not need the warning. But that's a
minor point.

- [Cancel] or [OK] now abort or apply sort/filter just the way it should
be IMO.

I've also checked for the other stuff I have reported recently and
replied on the thread where I've come up with something.
The rest seems to work like a charm now. Also no crashes or anything bad
and new.

- Rule privilege for VIEWs: partly fixed, see reply on thread.
- Refresh object name: seems FIXED.
- "FORCE" option for REINDEX: seems Robins FIXED it.
- Redundant double-quotes in types: seems FIXED.
- Errors & notices in pgAdmin log-files: seems FIXED.

Regards
Erwin

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2008-05-03 07:18:58 Re: Behavioral issues in data grid: unsaved data, sort/filter
Previous Message Dave Page 2008-05-02 21:48:42 Re: Behavioral issues in data grid: unsaved data, sort/filter