Re: pg_postmaster_reload_time() patch

From: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
To: "Gurjeet Singh" <singh(dot)gurjeet(at)gmail(dot)com>
Cc: "George Gensure" <werkt0(at)gmail(dot)com>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pg_postmaster_reload_time() patch
Date: 2008-04-30 10:11:16
Message-ID: 481845C4.4040009@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Gurjeet Singh wrote:
> On Wed, Apr 30, 2008 at 9:53 AM, George Gensure <werkt0(at)gmail(dot)com> wrote:
>
>> I've done a quick write up for reload time reporting from the
>> administration TODO. I was a little paranoid with the locking, but
>> didn't want problems to occur with signals on the postmaster and the
>> read side.
>>
>>
> IMHO, the function should return NULL if the postmaster never reloaded; that
> is, it was started, but never signaled to reload.

I think it's useful to get the server startup time if the configuration
has never been reloaded. That's when the configuration was loaded, if no
reload has been triggered since. Perhaps the function should be named to
reflect that better. pg_configuration_load_time() ?

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Heikki Linnakangas 2008-04-30 10:29:40 Re: Patch to add a feature to pg_standby
Previous Message KaiGai Kohei 2008-04-30 09:01:57 Re: [0/4] Proposal of SE-PostgreSQL patches