From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Gregory Stark <stark(at)enterprisedb(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Chris Browne <cbbrowne(at)acm(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Lessons from commit fest |
Date: | 2008-04-18 03:29:55 |
Message-ID: | 480815B3.4010102@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Gregory Stark wrote:
> But if we're still doing object file analysis on the build farm and it's easy
> to add typedefs manually then perhaps there's not much effort saved by having
> such a tool. I think it would be possible to write but it wouldn't really be
> easy. You have to parse just enough C to find the typedef but not so much you
> get confused by invalid C syntax caused by looking at both sides of #ifdef
> branches.
>
>
I am pretty dead sure that a textual analysis tool is going to be far
too much work to write and maintain, for the benefit we might get from it.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Smith | 2008-04-18 03:34:41 | Re: Lessons from commit fest |
Previous Message | Gregory Stark | 2008-04-18 03:23:42 | Re: Lessons from commit fest |