| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Brown <michael(dot)brown(at)discourse(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fdatasync performance problem with large number of DB files |
| Date: | 2021-03-18 06:13:16 |
| Message-ID: | 47abaf1d-4122-3fd0-c934-303da9ce1596@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/03/17 12:02, Thomas Munro wrote:
> On Tue, Mar 16, 2021 at 9:10 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>> Thanks for the patch!
>>
>> + When set to <literal>fsync</literal>, which is the default,
>> + <productname>PostgreSQL</productname> will recursively open and fsync
>> + all files in the data directory before crash recovery begins.
>>
>> Isn't this a bit misleading? This may cause users to misunderstand that
>> such fsync can happen only in the case of crash recovery.
>
> If I insert the following extra sentence after that one, is it better?
> "This applies whenever starting a database cluster that did not shut
> down cleanly, including copies created with pg_basebackup."
Yes. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2021-03-18 06:19:52 | Re: Detecting File Damage & Inconsistencies |
| Previous Message | Fujii Masao | 2021-03-18 06:09:28 | Re: Get memory contexts of an arbitrary backend process |