Re: Concurrent psql patch

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gregory Stark <stark(at)enterprisedb(dot)com>, David Fetter <david(at)fetter(dot)org>, Jim Nasby <decibel(at)decibel(dot)org>, pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Concurrent psql patch
Date: 2008-04-09 01:46:18
Message-ID: 47FC1FEA.3040103@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
> Tom Lane wrote:
>
>> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>>
>>> This has been saved for the next commit-fest:
>>> http://momjian.postgresql.org/cgi-bin/pgpatches_hold
>>>
>> Er, why "saved"? Until there's a new patch submission there's not going
>> to be more work to do on this in the next fest.
>>
>> I think maybe you need to think a bit harder about the distinction
>> between your TODO-items-in-waiting list and the commit fest queue.
>> I was willing to wade through a pile of TODO-items-in-waiting this
>> time, because I pressed you to make the list available before having
>> sorted through it; but I'm not going to be pleased to see those same
>> threads in the fest queue next time, unless someone's done some actual
>> work in between.
>>
>
> It is in the next fest so I will remember to ask if people have done any
> work on them --- if not they are either deleted or moved to the next
> commit fest.
>
> Are you suggesting we just delete the threads and let them die if they
> don't submit a new version?
>
>

My understanding was that all items in a commit-fest have one of these
three dispositions:

. committed
. rejected
. referred back to author for more work

We're really only interested in the third one here, and so, yes, the
ball should be in the author's court, not yours. I don't see any reason
for you to move items from one queue to another like that. It just looks
like it's making work.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2008-04-09 01:49:44 Re: [PATCHES] libpq type system 0.9a
Previous Message Tom Lane 2008-04-09 01:43:55 Re: Concurrent psql patch

Browse pgsql-patches by date

  From Date Subject
Next Message Merlin Moncure 2008-04-09 01:49:44 Re: [PATCHES] libpq type system 0.9a
Previous Message Tom Lane 2008-04-09 01:43:55 Re: Concurrent psql patch