Re: [PATCHES] libpq type system 0.9a

From: Andrew Chernow <ac(at)esilo(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Greg Sabino Mullane <greg(at)turnstep(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] libpq type system 0.9a
Date: 2008-04-09 01:27:32
Message-ID: 47FC1B84.60000@esilo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

This patch has an identity crisis. We initially called it PGparam (possibly
mispelled several times as PQparam) and then changed it to libpq type system
(typesys).

Several on patches started to call it libpqtypes, even I did. Any objections to
fixing the name to libpqtypes?

Any thoughts on the hooking suggested by Tom? It sounds like it should be
generic enough so more than just libpqtypes can make use of it. I think
something of this nature should have input before I do anything.

Possible Hook points: (at least ones needed by libpqtypes)
conn_create
conn_reset
conn_destroy
result_create
result_destroy

I guess libpqtypes would have to maintain a map of conns and results? Right now
it can associate type info because we added members to conn and result. When
conn_create(conn) is called, libpqtypes would need to map this by pointer
address (as it is all it has as an identifier). Still feels like maybe there
should be a void* in a conn and result used for per-connection/result based info
(libpqtypes or not).

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2008-04-09 01:28:03 Re: [PATCHES] libpq type system 0.9a
Previous Message Jeff Davis 2008-04-09 01:21:49 Re: [PATCHES] libpq type system 0.9a

Browse pgsql-patches by date

  From Date Subject
Next Message Jeff Davis 2008-04-09 01:28:03 Re: [PATCHES] libpq type system 0.9a
Previous Message Jeff Davis 2008-04-09 01:21:49 Re: [PATCHES] libpq type system 0.9a