Re: pgsql: Make integer_datetimes the default on msvc as well, to have the

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <mha(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make integer_datetimes the default on msvc as well, to have the
Date: 2008-04-09 00:09:23
Message-ID: 47FC0933.2040106@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Magnus Hagander wrote:
> Log Message:
> -----------
> Make integer_datetimes the default on msvc as well, to have the same
> default as other platforms.
>
> Modified Files:
> --------------
> pgsql/src/tools/msvc:
> config.pl (r1.9 -> r1.10)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/msvc/config.pl?r1=1.9&r2=1.10)
>
>

I don't actually think this is the right way to do this. It's not the
same thing. The equivalent behaviour would be to have the flag turned on
even if there's nothing in the config file. What I think we need is to
add this line in Solution.pm::new():

$options->{integer_datetimes} = 1 unless exists
$config->{integer_datetimes};

That way we turn the flag on if the config says nothing at all, but if
it says anything we respect what it says.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2008-04-09 00:18:49 Re: pgsql: Make integer_datetimes the default on msvc as well, to have the
Previous Message User Gleu 2008-04-08 21:31:02 pgsnap - pgsnap: Small typo.